mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-12 18:30:48 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #35988 -- Made BaseForm.full_clean() pass renderer to ErrorDict.

Browse Source
This commit is contained in:
Adam Johnson 2024-12-09 11:17:25 +00:00 committed by Sarah Boyce
parent 1860a1afc9
commit 02628c051c
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/forms/forms.py
View File

@ -316,7 +316,7 @@ class BaseForm(RenderableFormMixin):
""" """
Clean all of self.data and populate self._errors and self.cleaned_data. Clean all of self.data and populate self._errors and self.cleaned_data.
""" """
self._errors = ErrorDict() self._errors = ErrorDict(renderer=self.renderer)
if not self.is_bound: # Stop further processing. if not self.is_bound: # Stop further processing.
return return
self.cleaned_data = {} self.cleaned_data = {}

16
tests/forms_tests/tests/test_forms.py
View File

@ -5313,6 +5313,22 @@ class OverrideTests(SimpleTestCase):
"required></p>", "required></p>",
) )
def test_custom_renderer_error_dict(self):
class CustomRenderer(DjangoTemplates):
def render(self, template_name, context, request=None):
if template_name == "django/forms/errors/dict/default.html":
return "<strong>So many errors!</strong>"
return super().render(template_name, context, request)
form = Form({}, renderer=CustomRenderer())
form.full_clean()
form.add_error(None, "Test error")
self.assertHTMLEqual(
form.errors.render(),
"<strong>So many errors!</strong>",
)
def test_cyclic_context_boundfield_render(self): def test_cyclic_context_boundfield_render(self):
class FirstNameForm(Form): class FirstNameForm(Form):
first_name = CharField() first_name = CharField()