mirror of
https://github.com/django/django.git
synced 2025-10-23 21:59:11 +00:00
Fixed #25176 -- Prevented TestCase.setUpTestData() exception from leaking transaction.
This commit is contained in:
@@ -944,6 +944,39 @@ class OverrideSettingsTests(SimpleTestCase):
|
||||
self.assertIn(expected_location, finder.locations)
|
||||
|
||||
|
||||
class TestBadSetUpTestData(TestCase):
|
||||
"""
|
||||
An exception in setUpTestData() shouldn't leak a transaction which would
|
||||
cascade across the rest of the test suite.
|
||||
"""
|
||||
class MyException(Exception):
|
||||
pass
|
||||
|
||||
@classmethod
|
||||
def setUpClass(cls):
|
||||
try:
|
||||
super(TestBadSetupTestData, cls).setUpClass()
|
||||
except cls.MyException:
|
||||
cls._in_atomic_block = connection.in_atomic_block
|
||||
|
||||
@classmethod
|
||||
def tearDownClass(Cls):
|
||||
# override to avoid a second cls._rollback_atomics() which would fail.
|
||||
# Normal setUpClass() methods won't have exception handling so this
|
||||
# method wouldn't typically be run.
|
||||
pass
|
||||
|
||||
@classmethod
|
||||
def setUpTestData(cls):
|
||||
# Simulate a broken setUpTestData() method.
|
||||
raise cls.MyException()
|
||||
|
||||
def test_failure_in_setUpTestData_should_rollback_transaction(self):
|
||||
# setUpTestData() should call _rollback_atomics() so that the
|
||||
# transaction doesn't leak.
|
||||
self.assertFalse(self._in_atomic_block)
|
||||
|
||||
|
||||
class DisallowedDatabaseQueriesTests(SimpleTestCase):
|
||||
def test_disallowed_database_queries(self):
|
||||
expected_message = (
|
||||
|
||||
Reference in New Issue
Block a user