mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-05-29 18:26:29 +00:00
Code Issues 32 Releases Wiki Activity

Updated a test that doesn't make sense with autocommit.

Browse Source
This commit is contained in:
Aymeric Augustin 2013-03-07 17:20:15 +01:00
parent 423c0d5e29
commit 0cee3c0e43
1 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
tests/transactions_regress/tests.py
View File

@ -4,7 +4,7 @@ from django.db import connection, connections, transaction, DEFAULT_DB_ALIAS, Da
from django.db.transaction import commit_on_success, commit_manually, TransactionManagementError from django.db.transaction import commit_on_success, commit_manually, TransactionManagementError
from django.test import TransactionTestCase, skipUnlessDBFeature from django.test import TransactionTestCase, skipUnlessDBFeature
from django.test.utils import override_settings from django.test.utils import override_settings
from django.utils.unittest import skipIf, skipUnless, expectedFailure from django.utils.unittest import skipIf, skipUnless
from transactions.tests import IgnorePendingDeprecationWarningsMixin from transactions.tests import IgnorePendingDeprecationWarningsMixin
@ -187,22 +187,24 @@ class TestNewConnection(IgnorePendingDeprecationWarningsMixin, TransactionTestCa
connections[DEFAULT_DB_ALIAS].close() connections[DEFAULT_DB_ALIAS].close()
connections[DEFAULT_DB_ALIAS] = self._old_backend connections[DEFAULT_DB_ALIAS] = self._old_backend
# TODO: update this test to account for database-level autocommit.
@expectedFailure
def test_commit(self): def test_commit(self):
""" """
Users are allowed to commit and rollback connections. Users are allowed to commit and rollback connections.
""" """
# The starting value is False, not None. connection.set_autocommit(False)
self.assertIs(connection._dirty, False) try:
list(Mod.objects.all()) # The starting value is False, not None.
self.assertTrue(connection.is_dirty()) self.assertIs(connection._dirty, False)
connection.commit() list(Mod.objects.all())
self.assertFalse(connection.is_dirty()) self.assertTrue(connection.is_dirty())
list(Mod.objects.all()) connection.commit()
self.assertTrue(connection.is_dirty()) self.assertFalse(connection.is_dirty())
connection.rollback() list(Mod.objects.all())
self.assertFalse(connection.is_dirty()) self.assertTrue(connection.is_dirty())
connection.rollback()
self.assertFalse(connection.is_dirty())
finally:
connection.set_autocommit(True)
def test_enter_exit_management(self): def test_enter_exit_management(self):
orig_dirty = connection._dirty orig_dirty = connection._dirty