mirror of
https://github.com/django/django.git
synced 2025-10-28 16:16:12 +00:00
[1.10.x] Fixed #26747 -- Used more specific assertions in the Django test suite.
Backport of 4f336f6652 from master
This commit is contained in:
@@ -221,7 +221,7 @@ class SettingsTests(SimpleTestCase):
|
||||
getattr(settings, 'TEST')
|
||||
with self.settings(TEST='override'):
|
||||
self.assertEqual(self.testvalue, 'override')
|
||||
self.assertEqual(self.testvalue, None)
|
||||
self.assertIsNone(self.testvalue)
|
||||
|
||||
@override_settings(TEST='override')
|
||||
def test_signal_callback_decorator(self):
|
||||
@@ -403,24 +403,24 @@ class SecureProxySslHeaderTest(SimpleTestCase):
|
||||
def test_none(self):
|
||||
self.settings_module.SECURE_PROXY_SSL_HEADER = None
|
||||
req = HttpRequest()
|
||||
self.assertEqual(req.is_secure(), False)
|
||||
self.assertIs(req.is_secure(), False)
|
||||
|
||||
def test_set_without_xheader(self):
|
||||
self.settings_module.SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTOCOL', 'https')
|
||||
req = HttpRequest()
|
||||
self.assertEqual(req.is_secure(), False)
|
||||
self.assertIs(req.is_secure(), False)
|
||||
|
||||
def test_set_with_xheader_wrong(self):
|
||||
self.settings_module.SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTOCOL', 'https')
|
||||
req = HttpRequest()
|
||||
req.META['HTTP_X_FORWARDED_PROTOCOL'] = 'wrongvalue'
|
||||
self.assertEqual(req.is_secure(), False)
|
||||
self.assertIs(req.is_secure(), False)
|
||||
|
||||
def test_set_with_xheader_right(self):
|
||||
self.settings_module.SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTOCOL', 'https')
|
||||
req = HttpRequest()
|
||||
req.META['HTTP_X_FORWARDED_PROTOCOL'] = 'https'
|
||||
self.assertEqual(req.is_secure(), True)
|
||||
self.assertIs(req.is_secure(), True)
|
||||
|
||||
|
||||
class IsOverriddenTest(SimpleTestCase):
|
||||
|
||||
Reference in New Issue
Block a user