mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-12 10:22:37 +00:00
Code Issues 32 Releases Wiki Activity

Refs #36075 -- Adjusted pk_fields usage in bulk_update eligibility checks.

Browse Source 
Regression in bf7b17d16d3978b2e1cee4a0f7ce8840bd1a8dc4.

Thanks Sage Abdullah for the report.
This commit is contained in:
Simon Charette 2025-01-13 13:55:41 -05:00 committed by Sarah Boyce
parent 4bfec242b4
commit 161e79d277
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/db/models/query.py
View File

@ -878,7 +878,10 @@ class QuerySet(AltersData):
fields = [self.model._meta.get_field(name) for name in fields]
if any(not f.concrete or f.many_to_many for f in fields):
raise ValueError("bulk_update() can only be used with concrete fields.")
if any(f in self.model._meta.pk_fields for f in fields):
all_pk_fields = set(self.model._meta.pk_fields)
for parent in self.model._meta.all_parents:
all_pk_fields.update(parent._meta.pk_fields)
if any(f in all_pk_fields for f in fields):
raise ValueError("bulk_update() cannot be used with primary key fields.")
if not objs:
return 0

4
tests/queries/test_bulk_update.py
View File

@ -144,6 +144,10 @@ class BulkUpdateTests(TestCase):
with self.assertRaisesMessage(ValueError, self.pk_fields_error):
CustomPk.objects.bulk_update([], ["name"])
def test_update_inherited_primary_key(self):
with self.assertRaisesMessage(ValueError, self.pk_fields_error):
SpecialCategory.objects.bulk_update([], ["id"])
def test_empty_objects(self):
with self.assertNumQueries(0):
rows_updated = Note.objects.bulk_update([], ["note"])