mirror of
https://github.com/django/django.git
synced 2025-10-23 21:59:11 +00:00
Fixed ordering related test failure
Also PEP8 + python_2_unicode_compatible cleanup done.
This commit is contained in:
@@ -9,6 +9,9 @@ from django.utils.translation import activate
|
||||
from django.core.exceptions import FieldError
|
||||
from django import forms
|
||||
|
||||
# Note that these tests are testing internal implementation details.
|
||||
# ForeignObject is not part of public API.
|
||||
|
||||
class MultiColumnFKTests(TestCase):
|
||||
def setUp(self):
|
||||
# Creating countries
|
||||
@@ -142,9 +145,9 @@ class MultiColumnFKTests(TestCase):
|
||||
Membership.objects.create(membership_country=self.usa, person=self.jim, group=self.democrat)
|
||||
|
||||
with self.assertNumQueries(1):
|
||||
people = [m.person for m in Membership.objects.select_related('person')]
|
||||
people = [m.person for m in Membership.objects.select_related('person').order_by('pk')]
|
||||
|
||||
normal_people = [m.person for m in Membership.objects.all()]
|
||||
normal_people = [m.person for m in Membership.objects.all().order_by('pk')]
|
||||
self.assertEqual(people, normal_people)
|
||||
|
||||
def test_prefetch_foreignkey_forward_works(self):
|
||||
@@ -152,19 +155,22 @@ class MultiColumnFKTests(TestCase):
|
||||
Membership.objects.create(membership_country=self.usa, person=self.jim, group=self.democrat)
|
||||
|
||||
with self.assertNumQueries(2):
|
||||
people = [m.person for m in Membership.objects.prefetch_related('person')]
|
||||
people = [
|
||||
m.person for m in Membership.objects.prefetch_related('person').order_by('pk')]
|
||||
|
||||
normal_people = [m.person for m in Membership.objects.all()]
|
||||
normal_people = [m.person for m in Membership.objects.order_by('pk')]
|
||||
self.assertEqual(people, normal_people)
|
||||
|
||||
def test_prefetch_foreignkey_reverse_works(self):
|
||||
Membership.objects.create(membership_country=self.usa, person=self.bob, group=self.cia)
|
||||
Membership.objects.create(membership_country=self.usa, person=self.jim, group=self.democrat)
|
||||
with self.assertNumQueries(2):
|
||||
membership_sets = [list(p.membership_set.all())
|
||||
for p in Person.objects.prefetch_related('membership_set')]
|
||||
membership_sets = [
|
||||
list(p.membership_set.all())
|
||||
for p in Person.objects.prefetch_related('membership_set').order_by('pk')]
|
||||
|
||||
normal_membership_sets = [list(p.membership_set.all()) for p in Person.objects.all()]
|
||||
normal_membership_sets = [list(p.membership_set.all())
|
||||
for p in Person.objects.order_by('pk')]
|
||||
self.assertEqual(membership_sets, normal_membership_sets)
|
||||
|
||||
def test_m2m_through_forward_returns_valid_members(self):
|
||||
|
||||
Reference in New Issue
Block a user