mirror of
https://github.com/django/django.git
synced 2025-10-24 06:06:09 +00:00
Fixed #16340 -- Made get_or_create() re-raise any IntegrityError with its original traceback. Thanks to d0ugal and Jonas Obrist.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17333 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
@@ -1,6 +1,7 @@
|
||||
from __future__ import absolute_import
|
||||
|
||||
from datetime import date
|
||||
import traceback
|
||||
|
||||
from django.db import IntegrityError
|
||||
from django.test import TestCase
|
||||
@@ -52,3 +53,14 @@ class GetOrCreateTests(TestCase):
|
||||
ManualPrimaryKeyTest.objects.get_or_create, id=1, data="Different"
|
||||
)
|
||||
self.assertEqual(ManualPrimaryKeyTest.objects.get(id=1).data, "Original")
|
||||
|
||||
# get_or_create should raise IntegrityErrors with the full traceback.
|
||||
# This is tested by checking that a known method call is in the traceback.
|
||||
# We cannot use assertRaises/assertRaises here because we need to inspect
|
||||
# the actual traceback. Refs #16340.
|
||||
try:
|
||||
ManualPrimaryKeyTest.objects.get_or_create(id=1, data="Different")
|
||||
except IntegrityError, e:
|
||||
formatted_traceback = traceback.format_exc()
|
||||
self.assertIn('obj.save', formatted_traceback)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user