mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-13 10:50:55 +00:00
Code Issues 32 Releases Wiki Activity

Optimized DatabaseOperations.bulk_insert_sql() a bit on Oracle.

Browse Source
This commit is contained in:
Mariusz Felisiak 2024-03-11 13:24:18 +01:00 committed by GitHub
parent f2c3524959
commit 3592e9fcb1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
django/db/backends/oracle/operations.py
View File

@ -669,18 +669,20 @@ END;
return self._get_no_autofield_sequence_name(table) if row is None else row[0] return self._get_no_autofield_sequence_name(table) if row is None else row[0]
def bulk_insert_sql(self, fields, placeholder_rows): def bulk_insert_sql(self, fields, placeholder_rows):
field_placeholders = [
BulkInsertMapper.types.get(
getattr(field, "target_field", field).get_internal_type(), "%s"
)
for field in fields
if field
]
query = [] query = []
for row in placeholder_rows: for row in placeholder_rows:
select = [] select = []
for i, placeholder in enumerate(row): for i, placeholder in enumerate(row):
# A model without any fields has fields=[None]. # A model without any fields has fields=[None].
if fields[i]: if fields[i]:
internal_type = getattr( placeholder = field_placeholders[i] % placeholder
fields[i], "target_field", fields[i]
).get_internal_type()
placeholder = (
BulkInsertMapper.types.get(internal_type, "%s") % placeholder
)
# Add columns aliases to the first select to avoid "ORA-00918: # Add columns aliases to the first select to avoid "ORA-00918:
# column ambiguously defined" when two or more columns in the # column ambiguously defined" when two or more columns in the
# first select have the same value. # first select have the same value.