mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-12 18:30:48 +00:00
Code Issues 32 Releases Wiki Activity

[5.2.x] Fixed #36114 -- Fixed link visibility when list_display_links field contains only whitespace.

Browse Source 
Backport of e262d5355d82901f81fba6c7015643c2b87125bf from main.
This commit is contained in:
antoliny0919 2025-01-21 16:20:23 +09:00 committed by Sarah Boyce
parent 1df0f998ae
commit 5242220a56
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/contrib/admin/templatetags/admin_list.py
View File

@ -223,6 +223,8 @@ def items_for_result(cl, result, form):
empty_value_display = getattr( empty_value_display = getattr(
attr, "empty_value_display", empty_value_display attr, "empty_value_display", empty_value_display
) )
if isinstance(value, str) and value.strip() == "":
value = ""
if f is None or f.auto_created: if f is None or f.auto_created:
if field_name == "action_checkbox": if field_name == "action_checkbox":
row_classes = ["action-checkbox"] row_classes = ["action-checkbox"]

11
tests/admin_changelist/tests.py
View File

@ -1076,6 +1076,17 @@ class ChangeListTests(TestCase):
"http://blues_history.com</a>" % g.pk, "http://blues_history.com</a>" % g.pk,
) )
def test_blank_str_display_links(self):
self.client.force_login(self.superuser)
gc = GrandChild.objects.create(name=" ")
response = self.client.get(
reverse("admin:admin_changelist_grandchild_changelist")
)
self.assertContains(
response,
'<a href="/admin/admin_changelist/grandchild/%s/change/">-</a>' % gc.pk,
)
def test_clear_all_filters_link(self): def test_clear_all_filters_link(self):
self.client.force_login(self.superuser) self.client.force_login(self.superuser)
url = reverse("admin:auth_user_changelist") url = reverse("admin:auth_user_changelist")