mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-04 02:59:13 +00:00
Code Issues 32 Releases Wiki Activity

Avoided unnecessary usage of RawSQL.

Browse Source 
This ensures proper alias quoting.
This commit is contained in:
Simon Charette 2022-11-15 00:15:25 -05:00 committed by Mariusz Felisiak
parent 7a5307974a
commit 7adb0c8b60
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
django/db/models/sql/compiler.py
View File

@ -441,11 +441,11 @@ class SQLCompiler:
# Add column used in ORDER BY clause to the selected # Add column used in ORDER BY clause to the selected
# columns and to each combined query. # columns and to each combined query.
order_by_idx = len(self.query.select) + 1 order_by_idx = len(self.query.select) + 1
col_name = f"__orderbycol{order_by_idx}" col_alias = f"__orderbycol{order_by_idx}"
for q in self.query.combined_queries: for q in self.query.combined_queries:
q.add_annotation(expr_src, col_name) q.add_annotation(expr_src, col_alias)
self.query.add_select_col(resolved, col_name) self.query.add_select_col(resolved, col_alias)
resolved.set_source_expressions([RawSQL(f"{order_by_idx}", ())]) resolved.set_source_expressions([Ref(col_alias, src)])
sql, params = self.compile(resolved) sql, params = self.compile(resolved)
# Don't add the same column twice, but the order direction is # Don't add the same column twice, but the order direction is
# not taken into account so we strip it. When this entire method # not taken into account so we strip it. When this entire method