1
0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00

Simplify FilterExpression.args_check

This commit is contained in:
Curtis Maloney
2013-09-04 20:53:55 +10:00
committed by Tim Graham
parent 6dca603abb
commit 7c6f2ddcd9
2 changed files with 47 additions and 25 deletions

View File

@@ -622,34 +622,17 @@ class FilterExpression(object):
def args_check(name, func, provided):
provided = list(provided)
plen = len(provided)
# First argument, filter input, is implied.
plen = len(provided) + 1
# Check to see if a decorator is providing the real function.
func = getattr(func, '_decorated_function', func)
args, varargs, varkw, defaults = getargspec(func)
# First argument is filter input.
args.pop(0)
if defaults:
nondefs = args[:-len(defaults)]
else:
nondefs = args
# Args without defaults must be provided.
try:
for arg in nondefs:
provided.pop(0)
except IndexError:
# Not enough
alen = len(args)
dlen = len(defaults or [])
# Not enough OR Too many
if plen < (alen - dlen) or plen > alen:
raise TemplateSyntaxError("%s requires %d arguments, %d provided" %
(name, len(nondefs), plen))
# Defaults can be overridden.
defaults = list(defaults) if defaults else []
try:
for parg in provided:
defaults.pop(0)
except IndexError:
# Too many.
raise TemplateSyntaxError("%s requires %d arguments, %d provided" %
(name, len(nondefs), plen))
(name, alen - dlen, plen))
return True
args_check = staticmethod(args_check)