mirror of
				https://github.com/django/django.git
				synced 2025-10-31 09:41:08 +00:00 
			
		
		
		
	Fixed #21249 -- variable name typo in compiler.get_grouping()
The typo could have consequences in exceptional cases, but I didn't figure out a way to actually produce such a case, so not tests. Report & patch by Michael Manfre.
This commit is contained in:
		| @@ -575,7 +575,7 @@ class SQLCompiler(object): | |||||||
|                 for order, order_params in ordering_group_by: |                 for order, order_params in ordering_group_by: | ||||||
|                     # Even if we have seen the same SQL string, it might have |                     # Even if we have seen the same SQL string, it might have | ||||||
|                     # different params, so, we add same SQL in "has params" case. |                     # different params, so, we add same SQL in "has params" case. | ||||||
|                     if order not in seen or params: |                     if order not in seen or order_params: | ||||||
|                         result.append(order) |                         result.append(order) | ||||||
|                         params.extend(order_params) |                         params.extend(order_params) | ||||||
|                         seen.add(order) |                         seen.add(order) | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user