From 8c59905033e1a833f6c2f6f7aa7abad6d68926da Mon Sep 17 00:00:00 2001 From: Russell Keith-Magee Date: Wed, 9 Feb 2011 12:59:05 +0000 Subject: [PATCH] Fixed #15241 -- Updated the upgrading notes for generic views to reflect recent changes in class-based views. Thanks to Jonney for the report and patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15479 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/topics/generic-views-migration.txt | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/docs/topics/generic-views-migration.txt b/docs/topics/generic-views-migration.txt index b68f4a35a9..cac3f29844 100644 --- a/docs/topics/generic-views-migration.txt +++ b/docs/topics/generic-views-migration.txt @@ -128,12 +128,12 @@ as way to control the mimetype of the response. Class-based views don't provide a ``mimetype`` argument. Instead, you subclass the view, overriding -:meth:`TemplateResponseMixin.get_response()` and pass in arguments for -the HttpResponse constructor. For example:: +:meth:`TemplateResponseMixin.render_to_response()` and pass in arguments for +the TemplateResponse constructor. For example:: class MyListView(ListView): - def get_response(self, content, **kwargs): - return super(MyListView, self).get_response(content, + def render_to_response(self, context, **kwargs): + return super(MyListView, self).render_to_response(context, content_type='application/json', **kwargs) ``context_processors`` @@ -145,10 +145,9 @@ processors when rendering template content. Class-based views don't provide a ``context_processors`` argument. Instead, you subclass the view, overriding -:meth:`TemplateResponseMixin.get_context_instance()`. For example:: +:meth:`TemplateResponseMixin.render_to_response()`. For example:: class MyListView(ListView): - def get_context_instance(self, context): - return RequestContext(self.request, - context, - processors=[custom_processor]) + def render_to_response(self, context, **kwargs): + return super(MyListView, self).render_to_response( + RequestContext(self.request, context, processors=[custom_processor]), **kwargs)