1
0
mirror of https://github.com/django/django.git synced 2025-10-23 21:59:11 +00:00

Fixed #34606 -- Fixed Right() function with zero length on Oracle and SQLite.

This commit is contained in:
Kacper Wolkiewicz
2023-05-31 12:57:40 +02:00
committed by GitHub
parent b0a6cc7f57
commit 91be6e1818
3 changed files with 21 additions and 2 deletions

View File

@@ -1,5 +1,6 @@
from django.db import connection
from django.db.models import IntegerField, Value
from django.db.models.functions import Lower, Right
from django.db.models.functions import Length, Lower, Right
from django.test import TestCase
from ..models import Author
@@ -26,6 +27,21 @@ class RightTests(TestCase):
with self.assertRaisesMessage(ValueError, "'length' must be greater than 0"):
Author.objects.annotate(raises=Right("name", 0))
def test_zero_length(self):
Author.objects.create(name="Tom", alias="tom")
authors = Author.objects.annotate(
name_part=Right("name", Length("name") - Length("alias"))
)
self.assertQuerySetEqual(
authors.order_by("name"),
[
"mith",
"" if connection.features.interprets_empty_strings_as_nulls else None,
"",
],
lambda a: a.name_part,
)
def test_expressions(self):
authors = Author.objects.annotate(
name_part=Right("name", Value(3, output_field=IntegerField()))