Merged Unicode branch into trunk (r4952:5608). This should be fully

backwards compatible for all practical purposes.

Fixed #2391, #2489, #2996, #3322, #3344, #3370, #3406, #3432, #3454, #3492, #3582, #3690, #3878, #3891, #3937, #4039, #4141, #4227, #4286, #4291, #4300, #4452, #4702


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5609 bcc190cf-cafb-0310-a4f2-bffc1f526a37

django/db/backends/postgresql/base.py

@@ -4,6 +4,7 @@ PostgreSQL database backend for Django.
 Requires psycopg 1: http://initd.org/projects/psycopg1
 """
 
+from django.utils.encoding import smart_str, smart_unicode
 from django.db.backends import util
 try:
     import psycopg as Database
@@ -21,11 +22,6 @@ except ImportError:
     # Import copy of _thread_local.py from Python 2.4
     from django.utils._threading_local import local
 
-def smart_basestring(s, charset):
-    if isinstance(s, unicode):
-        return s.encode(charset)
-    return s
-
 class UnicodeCursorWrapper(object):
     """
     A thin wrapper around psycopg cursors that allows them to accept Unicode
@@ -33,18 +29,31 @@ class UnicodeCursorWrapper(object):
 
     This is necessary because psycopg doesn't apply any DB quoting to
     parameters that are Unicode strings. If a param is Unicode, this will
-    convert it to a bytestring using DEFAULT_CHARSET before passing it to
-    psycopg.
+    convert it to a bytestring using database client's encoding before passing
+    it to psycopg.
+
+    All results retrieved from the database are converted into Unicode strings
+    before being returned to the caller.
     """
     def __init__(self, cursor, charset):
         self.cursor = cursor
         self.charset = charset
 
+    def format_params(self, params):
+        if isinstance(params, dict):
+            result = {}
+            charset = self.charset
+            for key, value in params.items():
+                result[smart_str(key, charset)] = smart_str(value, charset)
+            return result
+        else:
+            return tuple([smart_str(p, self.charset, True) for p in params])
+
     def execute(self, sql, params=()):
-        return self.cursor.execute(sql, [smart_basestring(p, self.charset) for p in params])
+        return self.cursor.execute(smart_str(sql, self.charset), self.format_params(params))
 
     def executemany(self, sql, param_list):
-        new_param_list = [tuple([smart_basestring(p, self.charset) for p in params]) for params in param_list]
+        new_param_list = [self.format_params(params) for params in param_list]
         return self.cursor.executemany(sql, new_param_list)
 
     def __getattr__(self, attr):
@@ -83,7 +92,8 @@ class DatabaseWrapper(local):
         cursor = self.connection.cursor()
         if set_tz:
             cursor.execute("SET TIME ZONE %s", [settings.TIME_ZONE])
-        cursor = UnicodeCursorWrapper(cursor, settings.DEFAULT_CHARSET)
+        cursor.execute("SET client_encoding to 'UNICODE'")
+        cursor = UnicodeCursorWrapper(cursor, 'utf-8')
         global postgres_version
         if not postgres_version:
             cursor.execute("SELECT version()")
@@ -186,16 +196,17 @@ def get_sql_flush(style, tables, sequences):
     """
     if tables:
         if postgres_version[0] >= 8 and postgres_version[1] >= 1:
-            # Postgres 8.1+ can do 'TRUNCATE x, y, z...;'. In fact, it *has to* in order to be able to
-            # truncate tables referenced by a foreign key in any other table. The result is a
-            # single SQL TRUNCATE statement.
+            # Postgres 8.1+ can do 'TRUNCATE x, y, z...;'. In fact, it *has to*
+            # in order to be able to truncate tables referenced by a foreign
+            # key in any other table. The result is a single SQL TRUNCATE
+            # statement.
             sql = ['%s %s;' % \
                 (style.SQL_KEYWORD('TRUNCATE'),
                  style.SQL_FIELD(', '.join([quote_name(table) for table in tables]))
             )]
         else:
-            # Older versions of Postgres can't do TRUNCATE in a single call, so they must use
-            # a simple delete.
+            # Older versions of Postgres can't do TRUNCATE in a single call, so
+            # they must use a simple delete.
             sql = ['%s %s %s;' % \
                     (style.SQL_KEYWORD('DELETE'),
                      style.SQL_KEYWORD('FROM'),
@@ -263,6 +274,14 @@ def get_sql_sequence_reset(style, model_list):
                 style.SQL_TABLE(f.m2m_db_table())))
     return output
 
+def typecast_string(s):
+    """
+    Cast all returned strings to unicode strings.
+    """
+    if not s:
+        return s
+    return smart_unicode(s)
+
 # Register these custom typecasts, because Django expects dates/times to be
 # in Python's native (standard-library) datetime/time format, whereas psycopg
 # use mx.DateTime by default.
@@ -274,6 +293,7 @@ Database.register_type(Database.new_type((1083,1266), "TIME", util.typecast_time
 Database.register_type(Database.new_type((1114,1184), "TIMESTAMP", util.typecast_timestamp))
 Database.register_type(Database.new_type((16,), "BOOLEAN", util.typecast_boolean))
 Database.register_type(Database.new_type((1700,), "NUMERIC", util.typecast_decimal))
+Database.register_type(Database.new_type(Database.types[1043].values, 'STRING', typecast_string))
 
 OPERATOR_MAPPING = {
     'exact': '= %s',