mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #35845 -- Updated DomainNameValidator to require entire string to be a valid domain name.

Browse Source 
Bug in 4971a9afe5.

Thank you to kazet for the report and Claude Paroz for the review.
This commit is contained in:
Justin Thurman
2024-10-16 09:43:02 -04:00
committed by Sarah Boyce
parent 65f3cfce59
commit 99dcc59237
3 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/validators/tests.py
View File

@@ -635,8 +635,8 @@ TEST_DATA = [
(validate_domain_name, "python-python.com", None),
(validate_domain_name, "python.name.uk", None),
(validate_domain_name, "python.tips", None),
(validate_domain_name, "http://例子.测试", None),
(validate_domain_name, "http://dashinpunytld.xn---c", None),
(validate_domain_name, "例子.测试", None),
(validate_domain_name, "dashinpunytld.xn---c", None),
(validate_domain_name, "python..org", ValidationError),
(validate_domain_name, "python-.org", ValidationError),
(validate_domain_name, "too-long-name." * 20 + "com", ValidationError),
@@ -652,6 +652,16 @@ TEST_DATA = [
),
(DomainNameValidator(accept_idna=False), "ıçğü.com", ValidationError),
(DomainNameValidator(accept_idna=False), "not-domain-name", ValidationError),
(
DomainNameValidator(accept_idna=False),
"not-domain-name, but-has-domain-name-suffix.com",
ValidationError,
),
(
DomainNameValidator(accept_idna=False),
"not-domain-name.com, but has domain prefix",
ValidationError,
),
]
# Add valid and invalid URL tests.