mirror of
https://github.com/django/django.git
synced 2025-10-24 06:06:09 +00:00
Fixed #26601 -- Improved middleware per DEP 0005.
Thanks Tim Graham for polishing the patch, updating the tests, and writing documentation. Thanks Carl Meyer for shepherding the DEP.
This commit is contained in:
committed by
Tim Graham
parent
05c888ffb8
commit
9baf692a58
@@ -4,6 +4,7 @@ from __future__ import unicode_literals
|
||||
|
||||
import unittest
|
||||
|
||||
from django.core.exceptions import ImproperlyConfigured
|
||||
from django.core.handlers.wsgi import WSGIHandler, WSGIRequest, get_script_name
|
||||
from django.core.signals import request_finished, request_started
|
||||
from django.db import close_old_connections, connection
|
||||
@@ -166,6 +167,10 @@ class SignalsTests(SimpleTestCase):
|
||||
self.assertEqual(self.signals, ['started', 'finished'])
|
||||
|
||||
|
||||
def empty_middleware(get_response):
|
||||
pass
|
||||
|
||||
|
||||
@override_settings(ROOT_URLCONF='handlers.urls')
|
||||
class HandlerRequestTests(SimpleTestCase):
|
||||
|
||||
@@ -199,6 +204,12 @@ class HandlerRequestTests(SimpleTestCase):
|
||||
WSGIHandler()(environ, start_response)
|
||||
self.assertEqual(start_response.status, '200 OK')
|
||||
|
||||
@override_settings(MIDDLEWARE=['handlers.tests.empty_middleware'])
|
||||
def test_middleware_returns_none(self):
|
||||
msg = 'Middleware factory handlers.tests.empty_middleware returned None.'
|
||||
with self.assertRaisesMessage(ImproperlyConfigured, msg):
|
||||
self.client.get('/')
|
||||
|
||||
|
||||
class ScriptNameTests(SimpleTestCase):
|
||||
def test_get_script_name(self):
|
||||
|
||||
Reference in New Issue
Block a user