mirror of
https://github.com/django/django.git
synced 2025-05-29 18:26:29 +00:00
Fixed #25860 -- Documented a transaction leak possiblity in TestCase.
Thanks Jonas Haag for report and review.
This commit is contained in:
parent
59b57e672c
commit
a5619f7ed3
@ -685,13 +685,22 @@ then you should use :class:`~django.test.TransactionTestCase` or
|
|||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def setUpClass(cls):
|
def setUpClass(cls):
|
||||||
super(MyTestCase, cls).setUpClass() # Call parent first
|
super(MyTestCase, cls).setUpClass()
|
||||||
...
|
...
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
def tearDownClass(cls):
|
def tearDownClass(cls):
|
||||||
...
|
...
|
||||||
super(MyTestCase, cls).tearDownClass() # Call parent last
|
super(MyTestCase, cls).tearDownClass()
|
||||||
|
|
||||||
|
Be sure to account for Python's behavior if an exception is raised during
|
||||||
|
``setUpClass()``. If that happens, neither the tests in the class nor
|
||||||
|
``tearDownClass()`` are run. In the case of :class:`django.test.TestCase`,
|
||||||
|
this will leak the transaction created in ``super()`` which results in
|
||||||
|
various symptoms including a segmentation fault on some platforms (reported
|
||||||
|
on OS X). If you want to intentionally raise an exception such as
|
||||||
|
:exc:`unittest.SkipTest` in ``setUpClass()``, be sure to do it before
|
||||||
|
calling ``super()`` to avoid this.
|
||||||
|
|
||||||
TransactionTestCase
|
TransactionTestCase
|
||||||
~~~~~~~~~~~~~~~~~~~
|
~~~~~~~~~~~~~~~~~~~
|
||||||
|
Loading…
x
Reference in New Issue
Block a user