mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-06 23:42:33 +00:00
Code Issues 32 Releases Wiki Activity

Simplified Query.build_lookup()

Browse Source
This commit is contained in:
Anssi Kääriäinen 2014-11-10 15:38:03 +02:00
parent faf4d5c510
commit b3fd39f7c8
1 changed files with 37 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
django/db/models/sql/query.py
View File

@ -1109,28 +1109,48 @@ class Query(object):
self.check_query_object_type(v, opts) self.check_query_object_type(v, opts)
def build_lookup(self, lookups, lhs, rhs): def build_lookup(self, lookups, lhs, rhs):
"""
Tries to extract transforms and lookup from given lhs.
The lhs value is something that works like SQLExpression.
The rhs value is what the lookup is going to compare against.
The lookups is a list of names to extract using get_lookup()
and get_transform().
"""
lookups = lookups[:] lookups = lookups[:]
bilaterals = [] bilaterals = []
while lookups: while lookups:
lookup = lookups[0] name = lookups[0]
# If there is just one part left, try first get_lookup() so
# that if the lhs supports both transform and lookup for the
# name, then lookup will be picked.
if len(lookups) == 1: if len(lookups) == 1:
final_lookup = lhs.get_lookup(lookup) final_lookup = lhs.get_lookup(name)
if final_lookup: if not final_lookup:
# We didn't find a lookup. We are going to interpret
# the name as transform, and do an Exact lookup against
# it.
lhs = self.try_transform(lhs, name, lookups, bilaterals)
final_lookup = lhs.get_lookup('exact')
return final_lookup(lhs, rhs, bilaterals) return final_lookup(lhs, rhs, bilaterals)
# We didn't find a lookup, so we are going to try get_transform lhs = self.try_transform(lhs, name, lookups, bilaterals)
# + get_lookup('exact'). lookups = lookups[1:]
lookups.append('exact')
next = lhs.get_transform(lookup) def try_transform(self, lhs, name, rest_of_lookups, bilaterals):
"""
Helper method for build_lookup. Tries to fetch and initialize
a transform for name parameter from lhs.
"""
next = lhs.get_transform(name)
if next: if next:
lhs = next(lhs, lookups)
if getattr(next, 'bilateral', False): if getattr(next, 'bilateral', False):
bilaterals.append((next, lookups)) bilaterals.append((next, rest_of_lookups))
return next(lhs, rest_of_lookups)
else: else:
raise FieldError( raise FieldError(
"Unsupported lookup '%s' for %s or join on the field not " "Unsupported lookup '%s' for %s or join on the field not "
"permitted." % "permitted." %
(lookup, lhs.output_field.__class__.__name__)) (name, lhs.output_field.__class__.__name__))
lookups = lookups[1:]
def build_filter(self, filter_expr, branch_negated=False, current_negated=False, def build_filter(self, filter_expr, branch_negated=False, current_negated=False,
can_reuse=None, connector=AND): can_reuse=None, connector=AND):