mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 14:16:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #34621 -- Made admin site header render in <div> tag.

Browse Source 
This was problematic for screen reader users because they use headings
to navigate. Having two <h1> is confusing, and the one in the header
wasn’t particularly helpful since it’s the same on all pages.
This commit is contained in:
Howard Cox
2023-06-02 11:54:07 +01:00
committed by Mariusz Felisiak
parent 89c27d8672
commit cd413bd78a
8 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/admin_docs/test_views.py
View File

@@ -27,7 +27,7 @@ class AdminDocViewTests(TestDataMixin, AdminDocsTestCase):
self.assertContains(response, "<h1>Documentation</h1>", html=True)
self.assertContains(
response,
'<h1 id="site-name"><a href="/admin/">Django administration</a></h1>',
'<div id="site-name"><a href="/admin/">Django administration</a></div>',
)
self.client.logout()
response = self.client.get(reverse("django-admindocs-docroot"), follow=True)
@@ -153,7 +153,7 @@ class AdminDocViewTests(TestDataMixin, AdminDocsTestCase):
)
self.assertContains(
response,
'<h1 id="site-name"><a href="/admin/">Django administration</a></h1>',
'<div id="site-name"><a href="/admin/">Django administration</a></div>',
)
finally:
utils.docutils_is_available = True