From d7e0cf04b77c859d895e81ddb7af06a2ccfda5a7 Mon Sep 17 00:00:00 2001 From: Curtis Maloney Date: Sat, 13 Aug 2016 22:46:51 +1000 Subject: [PATCH] Used all() and a generator for PermissionsMixin.has_perms(). --- django/contrib/auth/models.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/django/contrib/auth/models.py b/django/contrib/auth/models.py index 725563424a..d49730b16b 100644 --- a/django/contrib/auth/models.py +++ b/django/contrib/auth/models.py @@ -280,10 +280,7 @@ class PermissionsMixin(models.Model): object is passed, it checks if the user has all required perms for this object. """ - for perm in perm_list: - if not self.has_perm(perm, obj): - return False - return True + return all(self.has_perm(perm, obj) for perm in perm_list) def has_module_perms(self, app_label): """