diff --git a/django/contrib/admin/templatetags/log.py b/django/contrib/admin/templatetags/log.py index 3db4452a55..427cb9521f 100644 --- a/django/contrib/admin/templatetags/log.py +++ b/django/contrib/admin/templatetags/log.py @@ -13,14 +13,13 @@ class AdminLogNode(template.Node): def render(self, context): if self.user is None: - context[self.varname] = LogEntry.objects.all().select_related('content_type', 'user')[:self.limit] + entries = LogEntry.objects.all() else: user_id = self.user if not user_id.isdigit(): user_id = context[self.user].pk - context[self.varname] = LogEntry.objects.filter( - user__pk=user_id, - ).select_related('content_type', 'user')[:int(self.limit)] + entries = LogEntry.objects.filter(user__pk=user_id) + context[self.varname] = entries.select_related('content_type', 'user')[:int(self.limit)] return '' diff --git a/tests/admin_changelist/tests.py b/tests/admin_changelist/tests.py index 2161c52f3e..7342e45830 100644 --- a/tests/admin_changelist/tests.py +++ b/tests/admin_changelist/tests.py @@ -3,11 +3,13 @@ from __future__ import unicode_literals import datetime from django.contrib import admin +from django.contrib.admin.models import LogEntry from django.contrib.admin.options import IncorrectLookupParameters from django.contrib.admin.templatetags.admin_list import pagination from django.contrib.admin.tests import AdminSeleniumWebDriverTestCase from django.contrib.admin.views.main import ALL_VAR, SEARCH_VAR, ChangeList from django.contrib.auth.models import User +from django.contrib.contenttypes.models import ContentType from django.core.urlresolvers import reverse from django.template import Context, Template from django.test import TestCase, override_settings @@ -685,6 +687,24 @@ class AdminLogNodeTestCase(TestCase): # it doesn't render any string. self.assertEqual(template.render(context), '') + def test_get_admin_log_templatetag_no_user(self): + """ + The {% get_admin_log %} tag should work without specifying a user. + """ + user = User(username='jondoe', password='secret', email='super@example.com') + user.save() + ct = ContentType.objects.get_for_model(User) + LogEntry.objects.log_action(user.pk, ct.pk, user.pk, repr(user), 1) + + t = Template( + '{% load log %}' + '{% get_admin_log 100 as admin_log %}' + '{% for entry in admin_log %}' + '{{ entry|safe }}' + '{% endfor %}' + ) + self.assertEqual(t.render(Context({})), 'Added "".') + @override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_changelist.urls")