From f3e5fba7c5d6fbfa8d8d0694eb4ab311f874de5d Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Thu, 25 Jun 2020 11:58:17 +0200 Subject: [PATCH] Simplified label element CSS in admin login.css. Don't add horizontal padding as the label is always displayed on its own line. This padding added no visual difference. Move the 'display: block' property from responsive.css to base.css. The label is already displayed on its own line in all viewports, so reduce differences in rendering. Using block also allows the label to consume the width of its container, creating a larger clickable area for a slight a11y improvement. --- django/contrib/admin/static/admin/css/login.css | 2 +- django/contrib/admin/static/admin/css/responsive.css | 2 -- django/contrib/admin/static/admin/css/rtl.css | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/django/contrib/admin/static/admin/css/login.css b/django/contrib/admin/static/admin/css/login.css index b60be90642..a270800a66 100644 --- a/django/contrib/admin/static/admin/css/login.css +++ b/django/contrib/admin/static/admin/css/login.css @@ -42,7 +42,7 @@ } .login .form-row label { - padding-right: 0.5em; + display: block; line-height: 2em; clear: both; } diff --git a/django/contrib/admin/static/admin/css/responsive.css b/django/contrib/admin/static/admin/css/responsive.css index 642640d2e5..562b852da3 100644 --- a/django/contrib/admin/static/admin/css/responsive.css +++ b/django/contrib/admin/static/admin/css/responsive.css @@ -897,9 +897,7 @@ input[type="submit"], button { } .login .form-row label { - display: block; margin: 0 0 5px; - padding: 0; line-height: 1.2; } diff --git a/django/contrib/admin/static/admin/css/rtl.css b/django/contrib/admin/static/admin/css/rtl.css index a4dae47d47..e5246367b5 100644 --- a/django/contrib/admin/static/admin/css/rtl.css +++ b/django/contrib/admin/static/admin/css/rtl.css @@ -6,8 +6,6 @@ .login .form-row label { float: right; - padding-left: 0.5em; - padding-right: 0; text-align: left; }