mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-14 11:20:46 +00:00
Code Issues 32 Releases Wiki Activity
32,636 Commits 29 Branches 437 Tags
Commit Graph

19648 Commits

Author SHA1 Message Date
Mariusz Felisiak
dafbed9af5
Refs #35004 -- Restored the direction of arrows in admin selector boxes for RTL languages on mobile screens. 
Regression in 57c1dd466ff0d41760049d6818e82be9d767c7da.
 2023-12-01 09:45:57 +01:00
Nick Pope
b925fefd7d Deprecated django.contrib.gis.geoip2.GeoIP2.coords(). 
The `ordering` argument is undocumented and of limited use, so this is
effectively the same as `GeoIP2.lon_lat()`.
 2023-12-01 08:38:42 +01:00
Nick Pope
1311f82a6a Simplified coordinate retrieval routines for GeoIP2. 
Also removed dead code checking for ``None`` as ``GeoIP2.city()` cannot
return ``None``.
 2023-12-01 08:23:52 +01:00
Tom Carrick
be06c39abe
Refs #35003 -- Corrected "wide" form margins in admin for LTR languages. 2023-12-01 06:07:32 +01:00
Tom Carrick
999ba9db6d Fixed #34995 -- Improved position of related widget's add link on admin pages on small screens. 
Regression in 1699f8b52ac15f687cc39088401c2641022c71cd.

Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>
 2023-11-30 14:21:44 -03:00
Tom Carrick
b34a4771a3
Fixed #35003 -- Corrected margins in admin for RTL languages. 2023-11-30 11:27:45 +01:00
Mariusz Felisiak
37fc832a54
Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite. 
Thanks Юрий for the report.

Regression in 78f163a4fb3937aca2e71786fbdd51a0ef39629e.
 2023-11-30 10:10:27 +01:00
Mariusz Felisiak
57c1dd466f
Fixed #35004 -- Corrected the direction of arrows in admin selector boxes for RTL languages on small screens. 
Follow up to 12617fbd859b1244e91bcf182a2fdf356b388821.
 2023-11-30 09:39:05 +01:00
Nick Pope
f5f55b41af
Removed unused GeoIP2.info property. 2023-11-29 21:03:35 +01:00
Adam Johnson
272ceb9584 Refs #25778 -- Updated some links and references to HTTPS. 2023-11-29 11:21:22 +01:00
Mariusz Felisiak
a4931cd75a
Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting. 
This allows early adoption of the new default "https".
 2023-11-28 20:04:21 +01:00
Nick Pope
5f9e5c1b0d Refs #34822, Refs #34986 -- Fixed migrations serializer support for functools.lru_cache(). 
It turns out that `functools._lru_cache_wrapper` is only a class when
CPython's _functools C module provides it, otherwise it is a function.
PyPy also provides it as a function.
 2023-11-28 13:47:35 +01:00
Nick Pope
051dbb5388 Refs #34986 -- Added PyPy support to django.utils.autoreload.get_child_arguments(). 
It seems that `sys._xoptions` is also supported on PyPy.
 2023-11-28 06:19:38 +01:00
Nick Pope
6089230d3e Refs #34986 -- Fixed mocking in utils_tests.test_http.HttpDateProcessingTests.test_parsing_rfc850. 
Mocking in the `datetime` module can be tricky. In CPython the datetime
C module is used, but PyPy uses a pure Python implementation. This
caused issues with the prior approach to mocking `datetime.datetime`.

See https://docs.python.org/3/library/unittest.mock-examples.html#partial-mocking
 2023-11-28 06:19:38 +01:00
Aman Pandey
0fcd72bc48 Fixed #34633 -- Made create() method of reverse many-to-one managers clear prefetch_related() cache. 2023-11-28 05:46:04 +01:00
Tom Carrick
729266c6f2 Fixed #34982 -- Fixed admin's read-only password widget and help texts alignment for tablet screen size. 
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
 2023-11-27 14:42:25 -03:00
Nick Pope
9baaf89eed Refs #34986 -- Added django.utils.version.PYPY. 2023-11-27 10:37:29 +01:00
Nick Pope
174369a990 Refs #34986 -- Avoided pickling error in DjangoUnicodeDecodeError. 
By using the existing object reference instead of a custom one, pickling
related issues when running the test suite in parallel can be avoided.
 2023-11-27 10:37:29 +01:00
Nathaniel Conroy
0257426fe1 Fixed #34992 -- Fixed DatabaseFeatures.allows_group_by_selected_pks on MariaDB with ONLY_FULL_GROUP_BY sql mode. 
Regression in 041551d716b69ee7c81199eee86a2d10a72e15ab.
 2023-11-27 09:20:10 +01:00
Simon Charette
978680db22
Refs #34925 -- Avoided altering passed by reference refresh_from_db(fields). 
Follow up to b0ec87b8578147be4357c90eabcd2b916c780810.
 2023-11-25 17:01:14 +01:00
trontelj
b0ec87b857 Fixed #34925 -- Prevented Model.refresh_from_db() from mutating list of fields. 2023-11-24 13:42:40 +01:00
Standa Opichal
1c6e8ec4ed Fixed #34968 -- Made multipart parsing of headers raise an error on too long headers. 
This also allow customizing the maximum size of headers via
MAX_TOTAL_HEADER_SIZE.
 2023-11-24 12:06:54 +01:00
Nick Pope
5e28cd3f2c
Fixed #34983 -- Deprecated django.utils.itercompat.is_iterable(). 2023-11-24 12:06:29 +01:00
Parth Verma
eabfa2d0e3
Fixed #34818 -- Prevented GenericIPAddressField from mutating error messages. 
Co-authored-by: Parth Verma <parth.verma@gmail.com>
 2023-11-24 05:46:17 +01:00
Prashant Pandey
a8adb6aa6c Fixed #26827 -- Improved ModelState error message when relations refer model classes. 2023-11-23 21:17:44 +01:00
Tom Carrick
a89c715c3b Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths. 
Regression in d687febce5868545f99974d2499a91f81a32fef5.
 2023-11-23 15:18:07 -03:00
Tom Carrick
4eb9c3d90a Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable. 
Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Thanks Tom Carrick for the report and fix.
 2023-11-23 09:39:57 -03:00
Tom Carrick
a03593967f Fixed #14611 -- Added query_params argument to RequestFactory and Client classes. 2023-11-23 10:39:29 +01:00
Simon Charette
e76cc93b01
Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations. 
Regression in f387d024fc75569d2a4a338bfda76cc2f328f627.

Just like `OrderByList` the `ExpressionList` expression used to wrap
`Window.partition_by` must implement `get_group_by_cols` to ensure the
necessary grouping when mixing window expressions with aggregate
annotations is performed against the partition members and not the
partition expression itself.

This is necessary because while `partition_by` is implemented as
a source expression of `Window` it's actually a fragment of the WINDOW
expression at the SQL level and thus it should result in a group by its
members and not the sum of them.

Thanks ElRoberto538 for the report.
 2023-11-23 06:09:08 +01:00
Mariusz Felisiak
101a85a5a0
Fixed #34985 -- Fixed GeneratedFields.contribute_to_class() crash when apps are not populated. 
Thanks Paolo Melchiorre for the report.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.
 2023-11-22 13:41:32 +01:00
Sarah Boyce
828082dad9 Fixed #34984 -- Skipped GeneratedFields when remaking tables on SQLite. 
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.t

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
 2023-11-22 12:29:14 +01:00
Mariusz Felisiak
7dd3e694db
Fixed #34980 -- Changed migration operation dependencies to namedtuples. 2023-11-21 10:22:32 +01:00
David Smith
f1697ec7c8
Refs #31026 -- Simplified BaseForm.get_context(). 
bf.errors returns an ErrorList. Access this directly and avoid creating
a new instance in BaseForm.get_context()

Calling str() on the ErrorList can also be deferred to when the
variable used in the template.
 2023-11-20 08:57:03 +01:00
Simon Charette
911b1619ab Refs #34975 -- Handled optional source expressions in Expression.get_refs(). 
While no code is directly exercising get_refs in a way that triggers
a crash some expressions such as Window stash None in source_expressions
which can obscure the origin of some bugs.

Handling None values like we do in other source_expression traversing
methods such as .contains_aggregates ensures we don't run into surprises
in the future where get_refs() might be used for a different purpose.
 2023-11-18 15:41:59 +01:00
Simon Charette
d7a9f006ed Refs #34717 -- Avoided computing aggregate refs twice. 2023-11-18 15:41:25 +01:00
Simon Charette
15cb3c262a Refs #34975 -- Complemented rhs filtering aggregations for __in lookup. 
While this isn't a regression it's clear that similar logic should be
applied when dealing with lists of expressions passed as a lookup value.
 2023-11-18 15:40:52 +01:00
Simon Charette
7530cf3900 Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations. 
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.

Regression in b181cae2e3697b2e53b5b67ac67e59f3b05a6f0d.

Refs #25307.

Thanks Sergey Nesterenko for the report.
 2023-11-18 15:38:04 +01:00
David Smith
eec7e9ba89 Refs #32819 -- Established relationship between form fieldsets and their help text. 
This adds aria-describedby for widgets rendered in a fieldset such as
radios. aria-describedby for these widgets is added to the <fieldset>
element rather than each <input>.
 2023-11-17 08:12:36 +01:00
David Smith
292f1ea90f Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field. 
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.

This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.
 2023-11-16 12:23:42 +01:00
Mariusz Felisiak
c705625ebf Refs #34944 -- Propagated system checks for GeneratedField.output_field. 2023-11-14 20:22:07 +01:00
Mariusz Felisiak
5875f03ce6 Fixed #34944 -- Made GeneratedField.output_field required. 
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.
 2023-11-14 20:22:07 +01:00
Mariusz Felisiak
de4884b114 Reverted "Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value()." 
This reverts commit 8b1acc0440418ac8f45ba48e2dfcf5126c83341b.
 2023-11-14 15:45:43 +01:00
Simon Charette
6364b6ee10 Fixed #34955 -- Made Concat() use || operator on PostgreSQL. 
This also avoids casting string based expressions in Concat() on
PostgreSQL.
 2023-11-14 10:56:20 +01:00
jedidiah
bdf30b952c Fixed #34919 -- Added scope attribute to admindocs model templates. 2023-11-14 05:34:56 +01:00
Andrew Cordery
ad41f1c53a Fixed #34952 -- Copied dir list when processing locale folders to avoid missing entries during os.walk traversal. 
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
 2023-11-13 14:03:48 -03:00
David Sanders
b863c5ffde Fixed #34967 -- Fixed queryset crash when grouping by constants on SQLite < 3.39. 
On SQLite < 3.39, this forces a GROUP BY clause with a HAVING clause
when no grouping is specified.

Co-authored-by: Simon Charette <charette.s@gmail.com>
 2023-11-13 12:01:40 +01:00
Adam Johnson
f7389c4b07 Fixed #34457 -- Restored output for makemigrations --check. 
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
 2023-11-09 10:03:19 -03:00
Simon Charette
8b1acc0440 Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value(). 
This should allow smarter output_field inferring in functions dealing
with text expressions.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.
 2023-11-08 15:48:15 +03:00
Natalia
5f2f12f61c Reverted "Fixed #34830 -- Added request to csrf_failure view's template context." 
This reverts commit 535f7b5c6cea54a0796d85bbe213183d50002689.
 2023-11-08 08:50:55 -03:00
Prakhar
535f7b5c6c Fixed #34830 -- Added request to csrf_failure view's template context. 
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
 2023-11-07 09:09:39 -03:00