mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity
22,897 Commits 30 Branches 460 Tags
57f7d8968d8443352ce331ad9dd6f433a15d0d93
Commit Graph

92 Commits

Author SHA1 Message Date
Alex Hill
db3eabfae5 [1.10.x] Refs #27039 -- Fixed regression with field defaults in prefixed forms. 
Backport of d9c083cfee from master
 2016-09-01 09:18:34 -04:00
Tim Graham
325dd0befe [1.10.x] Fixed #27039 -- Fixed empty data fallback to model field default in model forms. 
Backport of 4bc6b93994 from master
 2016-08-24 19:37:04 -04:00
Alex Hill
86ae2b22ae [1.10.x] Fixed #27001 -- Fixed a query count regression in ModelChoiceField with RadioSelect. 
Backport of c5ebfda002 from master
 2016-08-03 10:53:42 -04:00
Tim Graham
c6e5878410 [1.10.x] Fixed #26970 -- Fixed crash with disabled ModelMultipleChoiceField. 
Backport of 4e86168290 from master
 2016-07-30 20:45:37 -04:00
Tim Graham
3744fc1666 [1.10.x] Fixed #26917 -- Fixed crash in disabled ModelChoiceFields. 
Partially reverted refs #25532 to fix a regression in Django 1.10.
This reintroduces a crash for disabled forms.JSONField (refs #26949),
however, that issue is also present on Django 1.9.

Thanks Ryan Schave for the test.

Backport of a5f85d891b from master
 2016-07-27 08:36:49 -04:00
Andrey Fedoseev
ded5020241 [1.10.x] Fixed #17657 -- Made ModelForm respect ModelMultipleChoiceField's to_field_name. 
Follow up to 67d984413c.

Backport of 81963b37a9 from master
 2016-07-12 16:20:28 -04:00
Tim Graham
567cfc1601 [1.10.x] Replaced use of TestCase.fail() with assertRaises(). 
Also removed try/except/fail antipattern that hides exceptions.

Backport of c9ae09addf from master
 2016-07-01 09:58:56 -04:00
Tim Graham
1213ef2b18 [1.10.x] Refs #15667 -- Fixed crash when indexing RadioFieldRenderer with ModelChoiceIterator. 
Regression in 86573861a9
 2016-06-18 10:37:37 -04:00
Jon Dufresne
13d60298ea [1.10.x] Fixed #26747 -- Used more specific assertions in the Django test suite. 
Backport of 4f336f6652 from master
 2016-06-16 14:21:14 -04:00
Offby-One Kenobi
f2b2a35699 Fixed docstring typos. 2016-05-02 11:43:03 -04:00
Jon Dufresne
ec6121693f Fixed #22383 -- Added support for HTML5 required attribute on required form fields. 2016-04-21 19:16:38 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Yoong Kang Lim
d5f89ff6e8 Fixed #24974 -- Fixed inheritance of formfield_callback for modelform_factory forms. 2016-02-26 12:27:27 -05:00
Claude Paroz
d43156e1e9 Fixed #26238 -- Raised explicit error for non-editable field in ModelForm 
Thanks Luke Crouch for the report and Simon Charette for the review.
 2016-02-21 00:24:20 +01:00
haxoza
375e1cfe2b Fixed #25349 -- Allowed a ModelForm to unset a fields with blank=True, required=False. 2016-02-19 14:18:53 -05:00
Hasan
3d0dcd7f5a Refs #26022 -- Used context manager version of assertRaises in tests. 2016-01-29 12:32:18 -05:00
Tim Graham
6afa6818fc Fixed #25496 -- Made ModelChoiceField respect prefetch_related(). 2015-10-05 18:21:56 -04:00
Tim Graham
7cb3a48843 Fixed #25410 -- Fixed empty ClearableFileInput crash on Python 2. 
Reverted "Fixes #24727 -- Prevented ClearableFileInput from masking
exceptions on Python 2" and added a regression test.

This reverts commit 5c412dd8a7.
 2015-09-23 10:26:19 -04:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Keryn Knight
3c5862ccb0 Fixed #24706 -- Made ModelForm._post_clean() handle a ValidationError raised when constructing the model instance. 
Thanks Loïc Bistuer for review and advice.
 2015-09-07 14:36:39 -04:00
Tim Graham
f2b665f886 Fixed #25241 -- Corrected ModelForm.save() error message when saving invalid form with UUIDField pk. 2015-08-07 07:44:59 -04:00
Simon Charette
be67400b47 Refs #24652 -- Used SimpleTestCase where appropriate. 2015-05-20 13:46:13 -04:00
Bertrand Bordage
3e64f3d0fc Fixed #24531 -- Improved CommaSeparatedIntegerField validation. 
`','`, `'1,,1'`, `',1'` etc. are no longer considered as valid
comma-separated integer lists.
 2015-03-25 18:49:59 -04:00
Claude Paroz
b4a1bb8669 Updated test to be date-independent 
Fixes commit 8714403614.
 2015-03-05 10:08:39 +01:00
Claude Paroz
8714403614 Fixed #24428 -- Fixed has_changed for fields with coercion 
Thanks Carsten Fuchs for the report.
 2015-03-05 09:00:13 +01:00
Loic Bistuer
00a889167f Fixed #24295 -- Allowed ModelForm meta to specify form field classes. 
Thanks Carl Meyer and Markus Holtermann for the reviews.
 2015-02-13 19:13:05 +07:00
Collin Anderson
db77915c9f Fixed E265 comment style 2015-02-06 09:30:35 -05:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
Tim Graham
baf2542c4f Fixed DoS possibility in ModelMultipleChoiceField. 
This is a security fix. Disclosure following shortly.

Thanks Keryn Knight for the report and initial patch.
 2015-01-13 13:03:06 -05:00
Alasdair Nicol
5b26a014a8 Fixed #23865 -- documented how to assign errors to a field in Model.clean() 
Also added a unit test wit the simpler syntax which we have documented,
where the dictionary values are strings.
 2014-11-21 13:01:28 -05:00
Tim Graham
dec7da3c4c Fixed flake8 warning. 2014-11-13 10:07:44 +01:00
Baptiste Mispelon
bfb11b9562 Fixed #23795 -- Fixed a regression in custom form fields 
Custom form fields having a `queryset` attribute but no
`limit_choices_to` could no longer be used in ModelForms.

Refs #2445.

Thanks to artscoop for the report.
 2014-11-12 22:38:18 +01:00
Veres Lajos
a71a2ea756 Fixed typos using https://github.com/vlajos/misspell_fixer 2014-11-03 20:59:30 -05:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
Vincent-Vega
5e06fa1469 Fixed #22745 -- Prevented reevaluation of ModelChoiceField's queryset when accesssing BoundField's attrs. 
Thanks Christian Schmitt for review.
 2014-08-04 07:47:37 -04:00
Niclas Olofsson
cdc25ac474 Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types.. 
Thanks Mattias Lindvall for the report and inital patch.
 2014-07-31 15:29:46 -04:00
Tushar Bhatia
11181a64f9 Fixed #22979 -- Moved bug* tests 2014-07-26 21:05:49 -04:00
Anubhav Joshi
45e049937d Fixed #13776 -- Fixed ModelForm.is_valid() exception with non-nullable FK and blank=True. 
Thanks peterbe for the report.
 2014-06-04 07:57:19 -04:00
Marc Tamlyn
9fb0f5dddc Fixed #22510 -- Harden field removal to only None. 
Refs #8620.

If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.

Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.

Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
 2014-05-24 13:10:50 +01:00
Aymeric Augustin
cff59bedc2 Split ignores_nulls_in_unique_constraints feature. 
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
 2014-05-08 22:11:20 +02:00
Alex Gaynor
2bcb8bfc8d Fix many many typos in comments throughout the codebase 2014-04-26 10:18:45 -07:00
Claude Paroz
bf2b0affe4 Forgotten slash removal in d320863878 2014-03-26 19:51:17 +01:00
Tim Graham
ee4edb1eda Made ModelForms raise ImproperlyConfigured if the list of fields is not specified. 
Also applies to modelform(set)_factory and generic model views.

refs #19733.
 2014-03-22 07:56:48 -04:00
Tim Graham
e80de93af6 Removed hard-coded help_text for ManyToManyFields that use a SelectMultiple widget 
Per deprecation timeline; refs #9321.
 2014-03-21 19:10:07 -04:00
Tim Graham
4965a77407 Removed PIL compatability layer per deprecation timeline. 
refs #19934.
 2014-03-21 10:54:53 -04:00
Alex Gaynor
0cf158cf9a Fixed a small collection of flake8 violations that had snuck in 2014-03-20 10:30:41 -07:00
Claude Paroz
666a2ad22f Merged model_forms_regress with model_forms tests 2014-03-14 15:18:08 +01:00
Claude Paroz
72cfbdc10a Fixed #6103 -- Splitted tests in model_forms tests 2014-03-14 09:44:56 +01:00
Claude Paroz
210d0489c5 Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings 
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
 2014-03-08 09:57:40 +01:00
Chris Wilson
95c74b9d69 Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength 2014-03-05 20:09:28 +01:00