mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity
28,498 Commits 30 Branches 460 Tags
a503f5ebddb65f95e3656e46aab3ad672f09e128
Commit Graph

10999 Commits

Author SHA1 Message Date
Jon Dufresne
e703b93a65 Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags. 2019-12-11 09:49:54 +01:00
Baptiste Mispelon
d8e2333528 Fixed #31077 -- Made debug decorators raise TypeError if they're not called. 
Django will raise an error if you forget to call the decorator.
 2019-12-10 13:34:28 +01:00
Peter Andersen
02eff7ef60 Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs. 2019-12-10 12:27:50 +01:00
Mariusz Felisiak
3fb7c12158 Refs #23433 -- Fixed test_django_admin_py.DeprecationTest tests failures on Windows and Python < 3.8. 
subprocess.run()'s args parameter accepts a path-like object on Windows
since Python 3.8.
 2019-12-10 11:17:50 +01:00
Baptiste Mispelon
3df3c5e670 Fixed #26480 -- Fixed crash of contrib.auth.authenticate() on decorated authenticate() methods of authentication backends. 
The Signature API (PEP 362) has better support for decorated functions
(by default, it follows the __wrapped__ attribute set by
functools.wraps for example).
 2019-12-10 09:36:30 +01:00
Mariusz Felisiak
d6505273cd Refs #31044 -- Fixed error message when using Prefetch with a values_list() queryset. 2019-12-09 15:45:53 +01:00
Hasan Ramezani
4540842bc3 Fixed #31044 -- Errored nicely when using Prefetch with a raw() queryset. 2019-12-09 15:45:18 +01:00
Baptiste Mispelon
9e565386d3 Fixed #27430 -- Added -b/--buffer option to DiscoverRunner. 2019-12-09 13:47:12 +01:00
Mariusz Felisiak
f464526388 Refs #30676 -- Added test for invalid --pdb and --parallel usage in DiscoverRunner. 2019-12-09 11:12:06 +01:00
Alex Aktsipetrov
bf12273db4 Fixed #31060 -- Reallowed window expressions to be used in conditions outside of queryset filters. 
Regression in 4edad1ddf6.

Thanks utapyngo for the report.
 2019-12-06 13:52:16 +01:00
Jon Dufresne
5708327c37 Fixed #23433 -- Deprecated django-admin.py entry point in favor of django-admin. 
Unify on the entry point created by setuptools entry_points feature.
 2019-12-06 12:11:44 +01:00
Jon Dufresne
8eb0f73eed Refs #23433 -- Removed script argument from AdminScriptTestCase.run_test(). 2019-12-06 10:33:54 +01:00
Jon Dufresne
8aefe11137 Removed unnecessary __init__.py creation in admin_scripts.tests. 2019-12-06 09:57:09 +01:00
Mariusz Felisiak
82a88d2f48 Fixed #31061 -- Ignored positional args in django.urls.resolve() when all optional named parameters are missing. 
Regression in 76b993a117.

Thanks Claude Paroz for the report and Carlton Gibson for reviews.
 2019-12-06 09:32:51 +01:00
Hasan Ramezani
5d674eac87 Fixed #31039 -- Added support for contained_by lookup with AutoFields, SmallIntegerField, and DecimalField. 2019-12-05 15:50:39 +01:00
Carlton Gibson
6410d38ca7 Moved selenium import to nested scope. 2019-12-05 12:47:31 +01:00
Gordon Pendleton
adb9661789 Fixed #31010 -- Allowed subdomains of localhost in the Host header by default when DEBUG=True. 2019-12-05 09:44:45 +01:00
Aymeric Augustin
c06492dd87 Fixed #23524 -- Allowed DATABASES['TIME_ZONE'] option on PostgreSQL. 2019-12-04 18:22:08 +01:00
Baptiste Mispelon
26cab4e8c1 Fixed #31046 -- Allowed RelatedManager.add()/create()/set() to accept callable values in through_defaults. 2019-12-03 19:47:38 +01:00
Andrew Godwin
c90ab30fa1 Fixed #31056 -- Allowed disabling async-unsafe check with an environment variable. 2019-12-03 17:29:31 +01:00
Jon Dufresne
65285d1e7d Refs #29892 -- Made Selenium tests wait for popups to be ready. 2019-12-02 15:06:36 +01:00
Mariusz Felisiak
845042b3d9 Refs #25705 -- Fixed invalid SQL generated by SQLFuncMixin.as_sql() in custom_lookups tests. 
Generated SQL was invalid because parameters are quoted by a driver.
 2019-12-02 13:58:41 +01:00
Carlton Gibson
11c5e0609b Fixed CVE-2019-19118 -- Required edit permissions on parent model for editable inlines in admin. 
Thank you to Shen Ying for reporting this issue.
 2019-12-02 08:56:08 +01:00
Mariusz Felisiak
0107e3d105 Fixed #30953 -- Made select_for_update() lock queryset's model when using "self" with multi-table inheritance. 
Thanks Abhijeet Viswa for the report and initial patch.
 2019-12-02 07:57:19 +01:00
Carlton Gibson
c33eb6dcd0 Fixed #29892 -- Added explicit Selenium wait in admin autocomplete tests. 2019-11-29 14:03:22 +01:00
Baptiste Mispelon
f47ba7e780 Fixed #30255 -- Fixed admindocs errors when rendering docstrings without leading newlines. 
Used inspect.cleandoc() which implements PEP-257 instead of an internal
hook.
 2019-11-29 12:47:42 +01:00
Mariusz Felisiak
e8fcdaad5c Fixed #31021 -- Fixed proxy model permissions data migration crash with a multiple databases setup. 
Regression in 98296f86b3.
 2019-11-29 08:23:01 +01:00
Jon Dufresne
86a0231e0a Refs #23919 -- Replaced super(...) with super() in metaclasses. 2019-11-28 15:34:29 +01:00
Jon Dufresne
c8bd37a860 Fixed #31042 -- Removed AdminSeleniumTestCase.get_css_value() in favor of Selenium .is_displayed(). 
All instances of AdminSeleniumTestCase.get_css_value() were used to
inspect the display property.
 2019-11-28 15:10:13 +01:00
Jon Dufresne
875e3ff4fd Fixed #29892 -- Added .wait_page_loaded() in SeleniumTests.test_first_field_focus(). 2019-11-28 11:22:19 +01:00
Jon Dufresne
f0ed38edf3 Refs #29892 -- Replaced Selenium .submit() shim with .click() on the submit button. 
There is no WebDriver submit primitive. The Selenium project implements
it as a convenience only. The geckodriver developers recommend against
using it. Replace it with a real primitive, click on the submit button.

Fixes failing Seleninum test test_date_time_picker_shortcuts when using
the Firefox Selenium driver.
 2019-11-28 09:24:19 +01:00
Johannes Hoppe
249a6190ae Fixed #30975 -- Replaced custom get_select_option with Selenium's select_by_value. 2019-11-27 16:34:07 +01:00
Johannes Hoppe
69dbb6b708 Fixed #30973 -- Converted selenium tests wait_page_loaded to context manager. 2019-11-27 14:36:26 +01:00
Hasan Ramezani
8d32290279 Fixed #30425 -- Handled jinja2.TemplateSyntaxError when rendering a template. 
Jinja raises jinja2.TemplateSyntaxError in render() not in
get_template() when it's in an included template.
 2019-11-27 12:48:07 +01:00
Farhaan Bukhsh
1f817daa20 Fixed #30803 -- Allowed comma separators for milliseconds in django.utils.dateparse functions. 
Co-Authored-By: Ben Wilber <benwilber@gmail.com>
 2019-11-27 09:43:12 +01:00
Farhaan Bukhsh
42b23d1e79 Refs #30803 -- Allowed comma separators for decimal fractions in parse_duration(). 2019-11-27 09:43:12 +01:00
Baptiste Mispelon
52936eface Fixed #31031 -- Fixed data loss in admin changelist view when formset's prefix contains regex special chars. 
Regression in b18650a263.
 2019-11-26 08:48:10 +01:00
Simon Charette
0290e01d5a Fixed #31002 -- Fixed GIS lookups crash against a subquery annotation. 
Thanks Vasileios Bouzas for the report.
 2019-11-25 12:30:33 +01:00
John Bowen
29d8198841 Fixed #27914 -- Fixed serialization of nested classes in migrations. 2019-11-25 11:12:44 +01:00
John Bowen
8008795a38 Refs #23950 --- Moved test DeconstructibleInstances class to a module level. 
DeconstructibleInstances was not importable from the asserted path.
 2019-11-25 11:05:09 +01:00
Sergey Fedoseev
a5855c8f0f Fixed #30996 -- Added AsWKB and AsWKT GIS functions. 2019-11-22 13:40:48 +01:00
Baptiste Mispelon
8929afb8ec Fixed #9762 -- Made DateFormat.r() locale-independent. 
Thanks to Antonio Melé for the original report all those years ago
and to all the contributors who helped along the way.
 2019-11-22 12:41:53 +01:00
Baptiste Mispelon
76ec032712 Refs #26281 -- Added a helpful error message for an invalid "r" specifier to dateformat.format(). 2019-11-22 12:32:30 +01:00
Simon Charette
379bf1a2d4 Fixed #8467 -- Prevented crash when adding existent m2m relation with an invalid type. 
This was an issue anymore on backends that allows conflicts to be
ignored (Refs #19544) as long the provided values were coercible to the
expected type. However on the remaining backends that don't support
this feature, namely Oracle, this could still result in an
IntegrityError.

By attempting to coerce the provided values to the expected types in
Python beforehand we allow the existing value set intersection in
ManyRelatedManager._get_missing_target_ids to prevent the problematic
insertion attempts.

Thanks Baptiste Mispelon for triaging this old ticket against the
current state of the master branch.
 2019-11-22 09:08:10 +01:00
Simon Charette
8cc711999a Refs #8467 -- Added test for RelatedManager.add()/remove() with an invalid type. 2019-11-22 09:04:03 +01:00
Carlton Gibson
ee4a19053a Fixed #31012 -- Reverted "Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget." 
This reverts commit f038214d91.

The initial issue was incorrect. Django 2.2, and before, did not
generate invalid HTML as reported. With f03821 in place invalid HTML
was generated.

Thanks to Kevin Brown for follow-up report and investigation.
 2019-11-21 20:53:31 +01:00
Farhaan Bukhsh
664c98f1f8 Fixed #30413 -- Fixed test database signature on SQLite when test database name is provided. 
Previously, the same signature was created for multiple in-memory
databases on SQLite when they had tests databases names
DATABASES['TEST']['NAME'].
 2019-11-21 19:50:24 +01:00
Simon Charette
f97a6123c0 Refs #25367 -- Made Query.build_filter() raise TypeError on non-conditional expressions. 2019-11-21 11:56:35 +01:00
Simon Charette
e9a0e1d4f6 Fixed #30484 -- Added conditional expressions support to CheckConstraint. 2019-11-21 11:56:35 +01:00
Simon Charette
306b687520 Refs #11964 -- Removed SimpleCol in favor of Query(alias_cols). 
This prevent having to pass simple_col through multiple function calls
by defining whether or not references should be resolved with aliases
at the Query level.
 2019-11-21 11:56:35 +01:00