mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity
25,005 Commits 30 Branches 460 Tags
e80a014fceb64a0723174c296710e6b4c04d58d0
Commit Graph

81 Commits

Author SHA1 Message Date
Tim Graham
6e4c6281db Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()." 
This reverts commit 550cb3a365
because try/except performs better.
 2017-09-07 08:16:21 -04:00
Igor Tokarev
af35c69a3c Fixed #26344 -- Made EmailMessage include alternatives when the body is empty and it has attachments. 2017-09-04 08:46:11 -04:00
Mads Jensen
550cb3a365 Fixed #27818 -- Replaced try/except/pass with contextlib.suppress(). 2017-06-28 14:07:55 -04:00
kalombo
dd00184892 Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's attachments arg. 2017-04-07 18:02:34 -04:00
kalombo
aedfe0ddd7 Tested EmailMessage(attachments=[MIMEText]) 2017-04-07 18:01:31 -04:00
Claude Paroz
9a9e228321 Fixed #27848 -- Prevented crash when attaching a .eml file to a message 
Thanks Sébastien Ramage for the report.
 2017-04-01 16:19:03 +02:00
Claude Paroz
8346680e1c Refs #27795 -- Removed unneeded force_text calls 
Thanks Tim Graham for the review.
 2017-03-04 18:18:21 +01:00
Tim Graham
500532c95d Refs #23919 -- Removed default 'utf-8' argument for str.encode()/decode(). 2017-02-09 09:03:47 -05:00
Claude Paroz
c651331b34 Converted usage of ugettext* functions to their gettext* aliases 
Thanks Tim Graham for the review.
 2017-02-07 09:04:04 +01:00
Chillar Anand
6478e07a62 Refs #23919 -- Replaced tempfile.mkdtemp() with TemporaryDirectory() context manager. 2017-01-26 13:54:16 -05:00
Tim Graham
1c466994d9 Refs #23919 -- Removed misc Python 2/3 references. 2017-01-25 13:59:25 -05:00
chillaranand
d6eaf7c018 Refs #23919 -- Replaced super(ClassName, self) with super(). 2017-01-25 12:23:46 -05:00
Claude Paroz
042b7350a0 Refs #23919 -- Removed unneeded str() calls 2017-01-20 14:13:55 +01:00
Tim Graham
4e729feaa6 Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage. 
These functions do nothing on Python 3.
 2017-01-20 08:01:02 -05:00
Simon Charette
cecc079168 Refs #23919 -- Stopped inheriting from object to define new style classes. 2017-01-19 08:39:46 +01:00
Claude Paroz
2b281cc35e Refs #23919 -- Removed most of remaining six usage 
Thanks Tim Graham for the review.
 2017-01-18 21:33:28 +01:00
Claude Paroz
7b2f2e74ad Refs #23919 -- Removed six.<various>_types usage 
Thanks Tim Graham and Simon Charette for the reviews.
 2017-01-18 20:18:46 +01:00
Claude Paroz
c716fe8782 Refs #23919 -- Removed six.PY2/PY3 usage 
Thanks Tim Graham for the review.
 2017-01-18 16:21:28 +01:00
Claude Paroz
d7b9aaa366 Refs #23919 -- Removed encoding preambles and future imports 2017-01-18 09:55:19 +01:00
Claude Paroz
9390533951 Fixed #27696 -- Measured email long lines on encoded content 
Thanks Pavel Pokrovskiy for the report and Tim Graham for the review.
 2017-01-06 16:04:59 +01:00
za
321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Claude Paroz
8858631498 Fixed #27469 -- Prevented sending email to empty addresses 
Thanks Jarek Glowacki for the report.
 2016-11-10 19:47:02 +01:00
Jon Dufresne
9b9c8c4a81 Fixed #27368 -- Modifed BaseEmailBackend.__enter__() to close the connection if an exception occurs. 
Fixes unclosed socket ResourceWarning in mail test.

Thanks Claude Paroz for the review.
 2016-10-21 05:59:07 -07:00
Claude Paroz
458e2fbfcc Fixed #27333 -- Prevented BASE64 encoding in message.as_string() on Python 3 
Thanks Tim Graham for the review.
 2016-10-12 20:48:09 +02:00
Tim Graham
b2f9db1637 Removed redundant usage of assertNotIn() in a mail test. 
The Content-Transfer-Encoding header won't be repeated, so checking
the header is sufficient.
 2016-10-12 14:26:17 -04:00
Tim Graham
f6fe8ecc10 Refs #27210 -- Fixed isolation of test_fail_silently_on_connection_error. 
The test wouldn't pass if a mail server is running on the system.
 2016-09-30 12:22:52 -04:00
Vesteinn Snaebjarnarson
602bffe758 Fixed #27210 -- Allowed SMTPBackend to fail silently on a socket connection error. 2016-09-27 14:34:49 -04:00
levental
42dc9d0400 Fixed #26210 -- Prevented SMTP backend from trying to send mail after a connection failure. 2016-09-21 16:45:10 -04:00
Claude Paroz
fe252c0a5a Fixed #27131 -- Passed proper string type to SMTP connection login 
Passing an Unicode string on Python 2 was crashing the connection.
Thanks slavugan@gmail.com for the report, and Tim Graham for the review.
 2016-08-31 09:00:41 +02:00
Michael Schwarz
72d541b61c Fixed #27007 -- Handled non-UTF-8 bytes objects for text/* attachments. 
The fallback logic which allows non-UTF-8 encoded files to be passed to
attach_file() even when a `text/*` mime type has been specified is
moved to attach(). Both functions now fall back to a content type of
`application/octet-stream`.

A side effect is that a file's content is decoded in memory instead of
opening it in text mode and reading it into a string.

Some mimetype-related logic in _create_attachment() has become
obsolete as the code moved from attach_file() to attach() already
handles this.
 2016-08-12 16:35:09 -04:00
Antoine Fontaine
004ba05bca Fixed #27036 -- Made locmem email backend's send_messages() accept generators. 2016-08-08 20:13:29 -04:00
Michael Schwarz
6fe391d437 Refs #27007 -- Enhanced mail text attachment test 
The test now also checks whether the sent message's attachment has the expected
name, content and mime type.
 2016-08-07 19:18:08 +02:00
Claude Paroz
04b7b28812 Fixed #26802 -- Prevented crash when attaching bytes as text message 
Thanks Tim Graham for the review.
 2016-07-08 11:58:05 +02:00
Jon Dufresne
4f336f6652 Fixed #26747 -- Used more specific assertions in the Django test suite. 2016-06-16 14:19:18 -04:00
Simon Charette
271581df60 Refs #26712 -- Removed workarounds for PostgreSQL queries on TIME_ZONE changes. 2016-06-06 11:26:21 -04:00
Anton I. Sipos
c3495bb984 Fixed #12666 -- Added EMAIL_USE_LOCALTIME setting. 
When EMAIL_USE_LOCALTIME=True, send emails with a Date header
in the local time zone.
 2016-06-04 09:55:50 -04:00
Sergei Maertens
ec009ef1d8 Fixed #25986 -- Fixed crash sending email with non-ASCII in local part of the address. 
On Python 3, sending emails failed for addresses containing non-ASCII
characters due to the usage of the legacy Python email.utils.formataddr()
function. This is fixed by using the proper Address object on Python 3.
 2016-05-06 14:34:11 -04:00
Claude Paroz
836d475afe Fixed #22561 -- Prevented too long lines in email messages 
Thanks NotSqrt for the excellent report and Tim Graham for the review.
 2016-04-19 09:35:24 +02:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Hasan
253adc2b8a Refs #26022 -- Used context manager version of assertRaisesMessage in tests. 2016-01-29 13:03:39 -05:00
Hasan
3d0dcd7f5a Refs #26022 -- Used context manager version of assertRaises in tests. 2016-01-29 12:32:18 -05:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Konrad Świat
c6da621def Fixed #24623 -- Fixed EmailMessage.attach_file() with text files on Python 3. 
Thanks tkrapp for the report and Tim Graham for the review.
 2015-07-25 07:42:30 -04:00
Shai Berger
071801ccff Cleanup: Removed the try-except-fail antipattern from tests 
Found cases where testing code was doing

    try:
        whatever
    except (some excption type):
        self.fail("exception shouldn't be thrown")

replaced it with just

    whatever

as this makes the unexpected errors easier to debug, and the tests
would fail just as much and aren't rendered less readable.

Thanks Markus Holtermann for review
 2015-06-05 12:57:20 +03:00
Tim Graham
7d97c5745e Refs #23763 -- Fixed SMTPServer Python 3.5 deprecation warning in mail test. 2015-05-18 09:48:25 -04:00
medmunds
5993b52e6d Fixed #24416 -- Added support for lazy email addresses. 2015-03-13 12:33:49 -04:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
darkryder
9ec8aa5e5d Fixed #24149 -- Normalized tuple settings to lists. 2015-02-03 14:59:45 -05:00
Diego Guimarães
e32a8a99d9 Refs #23947 -- Isolated a mail test. 2014-12-06 12:06:06 -05:00
Martin Blech
e023ceb453 Fixed #23910 -- Added reply_to parameter to EmailMessage 
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
 2014-11-28 06:00:06 -05:00