mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Avoided direct styles in admin templates.

Browse Source 
Direct styles might be forbidden by Content Security Policies.
This commit is contained in:
Claude Paroz
2020-11-10 21:32:15 +01:00
committed by GitHub
parent 4cd77f97a2
commit 187482d743
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
django/contrib/admin/templates/admin/auth/user/change_password.html
View File

@@ -17,7 +17,7 @@
{% endif %}
{% block content %}<div id="content-main">
<form{% if form_url %} action="{{ form_url }}"{% endif %} method="post" id="{{ opts.model_name }}_form">{% csrf_token %}{% block form_top %}{% endblock %}
<input type="text" name="username" value="{{ original.get_username }}" style="display: none">
<input type="text" name="username" value="{{ original.get_username }}" class="hidden">
<div>
{% if is_popup %}<input type="hidden" name="_popup" value="1">{% endif %}
{% if form.errors %}

2
django/contrib/admin/templates/registration/password_reset_confirm.html
View File

@@ -17,7 +17,7 @@
<form method="post">{% csrf_token %}
<fieldset class="module aligned">
<input style="display: none;" autocomplete="username" value="{{ form.user.username }}">
<input class="hidden" autocomplete="username" value="{{ form.user.username }}">
<div class="form-row field-password1">
{{ form.new_password1.errors }}
<label for="id_new_password1">{% translate 'New password:' %}</label>

2
tests/admin_views/tests.py
View File

@@ -1170,7 +1170,7 @@ class AdminCustomTemplateTests(AdminViewBasicTestCase):
# When a site has multiple passwords in the browser's password manager,
# a browser pop up asks which user the new password is for. To prevent
# this, the username is added to the change password form.
self.assertContains(response, '<input type="text" name="username" value="super" style="display: none">')
self.assertContains(response, '<input type="text" name="username" value="super" class="hidden">')
def test_extended_bodyclass_template_index(self):
"""

2
tests/auth_tests/test_templates.py
View File

@@ -56,7 +56,7 @@ class AuthTemplateTests(TestCase):
# browser's password managers.
self.assertContains(
response,
'<input style="display: none;" autocomplete="username" value="jsmith">',
'<input class="hidden" autocomplete="username" value="jsmith">',
)
def test_PasswordResetCompleteView(self):