mirror of
				https://github.com/django/django.git
				synced 2025-10-31 09:41:08 +00:00 
			
		
		
		
	Added exception to SuspiciousOperation logging.
This allows better debugging and filtering of errors.
This commit is contained in:
		| @@ -98,6 +98,7 @@ def response_for_exception(request, exc): | ||||
|         security_logger = logging.getLogger('django.security.%s' % exc.__class__.__name__) | ||||
|         security_logger.error( | ||||
|             str(exc), | ||||
|             exc_info=exc, | ||||
|             extra={'status_code': 400, 'request': request}, | ||||
|         ) | ||||
|         if settings.DEBUG: | ||||
|   | ||||
| @@ -6,7 +6,9 @@ from admin_scripts.tests import AdminScriptTestCase | ||||
|  | ||||
| from django.conf import settings | ||||
| from django.core import mail | ||||
| from django.core.exceptions import PermissionDenied | ||||
| from django.core.exceptions import ( | ||||
|     DisallowedHost, PermissionDenied, SuspiciousOperation, | ||||
| ) | ||||
| from django.core.files.temp import NamedTemporaryFile | ||||
| from django.core.management import color | ||||
| from django.http.multipartparser import MultiPartParserError | ||||
| @@ -498,6 +500,7 @@ class SecurityLoggerTest(LoggingAssertionMixin, SimpleTestCase): | ||||
|             msg='dubious', | ||||
|             status_code=400, | ||||
|             logger='django.security.SuspiciousOperation', | ||||
|             exc_class=SuspiciousOperation, | ||||
|         ) | ||||
|  | ||||
|     def test_suspicious_operation_uses_sublogger(self): | ||||
| @@ -507,6 +510,7 @@ class SecurityLoggerTest(LoggingAssertionMixin, SimpleTestCase): | ||||
|             msg='dubious', | ||||
|             status_code=400, | ||||
|             logger='django.security.DisallowedHost', | ||||
|             exc_class=DisallowedHost, | ||||
|         ) | ||||
|  | ||||
|     @override_settings( | ||||
| @@ -516,7 +520,7 @@ class SecurityLoggerTest(LoggingAssertionMixin, SimpleTestCase): | ||||
|     def test_suspicious_email_admins(self): | ||||
|         self.client.get('/suspicious/') | ||||
|         self.assertEqual(len(mail.outbox), 1) | ||||
|         self.assertIn('Report at /suspicious/', mail.outbox[0].body) | ||||
|         self.assertIn('SuspiciousOperation at /suspicious/', mail.outbox[0].body) | ||||
|  | ||||
|  | ||||
| class SettingsCustomLoggingTest(AdminScriptTestCase): | ||||
|   | ||||
		Reference in New Issue
	
	Block a user