mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 01:25:32 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #30436 -- Added check that on_delete is callable in ForeignKey and OneToOneField.

Browse Source
This commit is contained in:
Rob
2019-05-12 20:58:35 +10:00
committed by Mariusz Felisiak
parent 330638b89f
commit c231a75112
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
django/db/models/fields/related.py
View File

@@ -797,6 +797,8 @@ class ForeignKey(ForeignObject):
# the to_field during FK construction. It won't be guaranteed to
# be correct until contribute_to_class is called. Refs #12190.
to_field = to_field or (to._meta.pk and to._meta.pk.name)
if not callable(on_delete):
raise TypeError('on_delete must be callable.')
kwargs['rel'] = self.rel_class(
self, to, to_field,

7
tests/delete/tests.py
View File

@@ -21,6 +21,13 @@ class OnDeleteTests(TestCase):
a.auto.delete()
self.assertFalse(A.objects.filter(name='auto').exists())
def test_non_callable(self):
msg = 'on_delete must be callable.'
with self.assertRaisesMessage(TypeError, msg):
models.ForeignKey('self', on_delete=None)
with self.assertRaisesMessage(TypeError, msg):
models.OneToOneField('self', on_delete=None)
def test_auto_nullable(self):
a = create_a('auto_nullable')
a.auto_nullable.delete()