mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 01:25:32 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #35815 -- Made system check accept db_default literals when DatabaseFeatures.supports_expression_defaults = False.

Browse Source
This commit is contained in:
Tim Graham
2024-10-08 20:25:48 -04:00
committed by Sarah Boyce
parent 63dbe30d33
commit c4614b53d3
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
django/db/models/fields/__init__.py
View File

@@ -392,7 +392,10 @@ class Field(RegisterLookupMixin):
if (
self.db_default is NOT_PROVIDED
or isinstance(self.db_default, Value)
or (
isinstance(self.db_default, Value)
or not hasattr(self.db_default, "resolve_expression")
)
or databases is None
):
return []

17
tests/invalid_models_tests/test_ordinary_fields.py
View File

@@ -1207,6 +1207,23 @@ class InvalidDBDefaultTests(TestCase):
expected_error = Error(msg=msg, obj=field, id="fields.E012")
self.assertEqual(errors, [expected_error])
def test_literals_not_treated_as_expressions(self):
"""
DatabaseFeatures.supports_expression_defaults = False shouldn't
prevent non-expression literals (integer, float, boolean, etc.) from
being used as database defaults.
"""
class Model(models.Model):
field = models.FloatField(db_default=1.0)
field = Model._meta.get_field("field")
with unittest.mock.patch.object(
connection.features, "supports_expression_defaults", False
):
errors = field.check(databases=self.databases)
self.assertEqual(errors, [])
@isolate_apps("invalid_models_tests")
class GeneratedFieldTests(TestCase):